Repository navigation
Propagate progress callback exceptions - #21
Open
kristjanvalur wants to merge 14 commits into
Open
kristjanvalur wants to merge 14 commits into
kristjanvalur wants to merge 14 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kristjanvalur
marked this pull request as ready for review
November 14, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency and review scope
This PR is based on #17 (keepalive callback exception handling). Because GitHub does not support native cross-fork stacked PRs, its base is upstream
master, so the diff currently includes all changes from #17 as well as the progress changes. Please review #17 first.For the progress-only diff while #17 is open, see the comparison against the keepalive branch or the fork-local draft. Once #17 is merged, the branch may need updating depending on the merge method.
Progress changes
Validation
testProgress,testSetbreakandtestCallbackExceptions.